Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
==========================================
- Coverage 96.53% 96.14% -0.40%
==========================================
Files 24 24
Lines 924 960 +36
==========================================
+ Hits 892 923 +31
- Misses 32 37 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@copilot Add test coverages to address #727 (comment) based on the existing tests. |
Adds comprehensive test coverage for the new Rive integration version resolution mechanism that selects between Classic (<0.14.0) and 0.14.0+ implementations. ## Tests Added - **Version resolution logic**: Validates factory constructor returns correct integration class based on `resolvedVersion` (from pubspec.lock) and `resolvedVersionConstraint` (from pubspec.yaml) - **Resolution priority**: Confirms `resolvedVersion` takes precedence over `resolvedVersionConstraint` when both present - **Fallback behavior**: Verifies RiveIntegration0140 is used when no version information available - **Generated output validation**: Ensures Classic generates `rive()` method with `RiveAnimation.asset`, while 0.14.0+ generates `riveFileLoader()` with `FileLoader.fromAsset` - **Package handling**: Tests both integration classes correctly handle package parameter ## Coverage Tests cover version boundaries (0.13.0, 0.14.0, 0.15.0) and constraint scenarios (^0.14.0, >=0.13.0 <0.14.0, ^0.12.0). <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Member
Author
|
@copilot Add test coverage to address https://app.codecov.io/gh/FlutterGen/flutter_gen/pull/727?src=pr&el=tree |
8 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #695 🎯
The PR introduces a new mechanism that detects the resolved version of integration packages in
pubspec.lockto determine which integration should be used. For example, generate different content for Rive >=0.14 and <0.14Unfortunately, we can no longer provide the widget builder for Rive, but the
FileLoaderinstead.Type of change